Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node version for storm-replay #21

Closed
GaryIrick opened this issue Jun 9, 2020 · 3 comments
Closed

Node version for storm-replay #21

GaryIrick opened this issue Jun 9, 2020 · 3 comments
Labels
upstream Issues that are present upstream, not here.

Comments

@GaryIrick
Copy link
Contributor

I'm opening an issue here, since the storm-replay repo is readonly. What Node versions does it support? I am having trouble building it with 12.6.3, don't know if that's expected to work, or I am ice-skating uphill.

I don't need anything fixed for now, just need the info.

Thanks!
@jnovack
Copy link
Member

jnovack commented Jun 10, 2020

Well, it was last built and tested by me for node8.

@jnovack
Copy link
Member

jnovack commented Jun 10, 2020

I just republished the latest working version that passes tests for node 8.

Newer versions of node-gyp and mocha cause issues with node 8. If I am bored, I'll try to update to node 10, then 12.

@jnovack
Copy link
Member

jnovack commented Jun 10, 2020 •
edited
Loading

Tested and working under node v10.21.0 and node gyp v6.1.0

https://github.com/nydus/storm-replay/blob/master/package.json#L27

nydus/storm-replay#9

@jnovack jnovack closed this as completed Jun 10, 2020
@jnovack jnovack added the upstream Issues that are present upstream, not here. label Jun 10, 2020
@jnovack jnovack mentioned this issue Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream Issues that are present upstream, not here.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnovack @GaryIrick