Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYTPhotosViewController crashes on tapping Share button on iPad #28

Closed
mpkeefe opened this issue Mar 24, 2015 · 2 comments
Closed

NYTPhotosViewController crashes on tapping Share button on iPad #28

mpkeefe opened this issue Mar 24, 2015 · 2 comments
Labels

Comments

@mpkeefe
Copy link
Contributor

mpkeefe commented Mar 24, 2015

I made a sample app (PRs: #25 #27) in Swift that mimics the current example ObjC app and runs on both iPhone and iPad, using the built-in NYTPhotosViewController. On iPad, the ShareActivityViewController crashes because it needs to be presented inside a popover. This can be done in iOS 8 simply by setting shareActivityViewController.popoverPresentationController?.barButtonItem but on iOS 7 will need to wrap inside a UIPopoverController I guess. Are there any other considerations?

@bcapps bcapps added the bug label Mar 25, 2015
@cdzombak
Copy link
Contributor

cdzombak commented May 1, 2015

The Swift example project is iOS 8-only, I believe, and the Share button works fine on the iPad Simulator.

The ObjC example app currently doesn't seem to work on the iPad at all :/

@heikkihautala
Copy link
Contributor

Created a PR for this: #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants