From 7334a70411ce88a90e71c3528e6a54bb1c8d304c Mon Sep 17 00:00:00 2001 From: Miroslav Bauer <mirekys@gmail.com> Date: Fri, 26 Jan 2024 19:36:02 +0100 Subject: [PATCH] chore(sonar): address issues --- .../ConfirmationModal/ConfirmationModal.jsx | 10 ++++++++++ .../forms/components/DeleteButton/DeleteButton.jsx | 2 +- .../FormikStateLogger/FormikStateLogger.jsx | 11 +++++++++-- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/ConfirmationModal/ConfirmationModal.jsx b/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/ConfirmationModal/ConfirmationModal.jsx index d215a5a3..784acc1f 100644 --- a/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/ConfirmationModal/ConfirmationModal.jsx +++ b/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/ConfirmationModal/ConfirmationModal.jsx @@ -1,5 +1,6 @@ import React from "react"; import { Modal, Icon, Message } from "semantic-ui-react"; +import PropTypes from "prop-types"; export function ConfirmationModal({ header, @@ -35,4 +36,13 @@ export function ConfirmationModal({ ); } +ConfirmationModal.propTypes = { + header: PropTypes.string, + content: PropTypes.string, + trigger: PropTypes.element, + actions: PropTypes.node, + isOpen: PropTypes.bool, + close: PropTypes.func, +}; + export default ConfirmationModal; diff --git a/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/DeleteButton/DeleteButton.jsx b/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/DeleteButton/DeleteButton.jsx index 09d01b14..8f345779 100644 --- a/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/DeleteButton/DeleteButton.jsx +++ b/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/DeleteButton/DeleteButton.jsx @@ -1,5 +1,5 @@ import React from "react"; -import { Button, Icon } from "semantic-ui-react"; +import { Button } from "semantic-ui-react"; import { i18next } from "@translations/i18next"; import { useConfirmationModal, diff --git a/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/FormikStateLogger/FormikStateLogger.jsx b/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/FormikStateLogger/FormikStateLogger.jsx index 3665484c..51329001 100644 --- a/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/FormikStateLogger/FormikStateLogger.jsx +++ b/oarepo_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/FormikStateLogger/FormikStateLogger.jsx @@ -1,15 +1,16 @@ import React from "react"; import { useFormikContext } from "formik"; import { Message } from "semantic-ui-react"; +import PropTypes from "prop-types"; // component to visualize formik state on screen during development -export const FormikStateLogger = ({ target = "" }) => { +export const FormikStateLogger = ({ render = false }) => { const state = useFormikContext(); if (process.env.NODE_ENV !== "development") { return; } - if (target === "dom") { + if (render) { return ( <Message> <Message.Header>Current record state</Message.Header> @@ -21,3 +22,9 @@ export const FormikStateLogger = ({ target = "" }) => { console.debug("[form state]: ", state, "\n[form values]:", state.values); return <></>; }; + +FormikStateLogger.propTypes = { + render: PropTypes.bool, +}; + +export default FormikStateLogger;