Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofl build sgx: Automatically define env variable with the latest state root #291

Open
matevz opened this issue Sep 19, 2024 · 1 comment · May be fixed by #335
Open

rofl build sgx: Automatically define env variable with the latest state root #291

matevz opened this issue Sep 19, 2024 · 1 comment · May be fixed by #335
Assignees
Labels
enhancement New feature or request rofl ROFL related CLI issues

Comments

@matevz
Copy link
Member

matevz commented Sep 19, 2024

Currently the state root is hardcoded inside each ROFL source code which looks awful:
https://github.com/oasisprotocol/oasis-sdk/blob/8545062a0a86f0567ce63ac549bada917019dfab/examples/runtime-sdk/rofl-oracle/src/main.rs#L22-L28

Let the Oasis CLI do the detection based on the provided network and ParaTime and store it inside an env variable before compilation, if it's a production build. Otherwise leave undefined. In the example above, a developer would simply read an env variable content if set or use None otherwise.

@matevz matevz added enhancement New feature or request rofl ROFL related CLI issues labels Sep 19, 2024
@kostko
Copy link
Member

kostko commented Jan 10, 2025

This has been solved as part of #335 where the trust root can be obtained automatically and configured as an environment variable. So if the methods are not overriden, these values will be retrieved from the environment variables.

@kostko kostko linked a pull request Jan 10, 2025 that will close this issue
@kostko kostko self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rofl ROFL related CLI issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants