Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change oasis net add <name> <chain-context> <rpc-endpoint> → oasis net add <name> <rpc-endpoint> [chain-context] #303

Closed
matevz opened this issue Oct 7, 2024 · 0 comments · Fixed by #321
Closed

Change oasis net add <name> <chain-context> <rpc-endpoint> → oasis net add <name> <rpc-endpoint> [chain-context] #303

matevz opened this issue Oct 7, 2024 · 0 comments · Fixed by #321
Assignees
@amela
Labels
enhancement New feature or request

Comments

@matevz
Copy link
Member

matevz commented Oct 7, 2024

When adding a network, support auto-detecting the chain context ID.

One possible solution would be to change the order of positional arguments:

oasis net add <name> <chain-context> <rpc-endpoint>

to

oasis net add <name> <rpc-endpoint> [chain-context]

and make the chain-context auto-detectable, if none provided. If one is provided, then keep the current "offline" behavior (useful for configuring the Oasis CLI upfront without network access).

Related #284
@matevz matevz added the enhancement New feature or request label Oct 7, 2024
@amela amela linked a pull request Nov 18, 2024 that will close this issue
feat(cmd/network/add): Make the chain context optional #321
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amela amela

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cmd/network/add): Make the chain context optional oasisprotocol/cli
2 participants
@matevz @amela