User-configurable stack name in init-odkx-sync-endpoint.py

[linl33]

init-odkx-sync-endpoint.py hard-coded the stack name syncldap. A user-configurable stack name would be useful.

Repository https://github.com/odk-x/sync-endpoint-default-setup

[adityaofficial10]

Hey!
@linl33
So we need to ask the user for the stack name right?
Can I work on this issue?

[linl33]

Hi @adityaofficial10!

Yes, you can work on this issue.
The idea is that the script should prompt for a stack name but default to syncldap (the current name). The script should also store the chosen stack name to its settings file.

[adityaofficial10]

@linl33
Sure, I'll follow this up with a PR shortly.

[adityaofficial10]

@linl33
I have made the changes as shown below:

Is this fine?
Also, you were talking about the settings file.
Which file is that exactly?

[linl33]

The function is correct but a few notes on the implementation,

• Please move the prompt into run_interactive_config, to keep it consistent with the rest of the configuration
• Please put the default value into [()], e.g. Please enter a name for the Docker Swarm stack [(syncldap)]
• Please use String interpolation instead of concatenation

For the settings file, see https://github.com/odk-x/sync-endpoint-default-setup/blob/0d97f322b6f3c48f86cdb47c9c1c7acf3f7bfb93/init-odkx-sync-endpoint.py#L134

Let me know if you have questions. Thanks for the work so far!

[adityaofficial10]

@linl33
I've made the required changes.
I'm sending you a link to the file in my fork. Kindly review and inform if I can improve something.
https://github.com/adityaofficial10/sync-endpoint-default-setup/blob/fix/stack-name-added/init-odkx-sync-endpoint.py
Can I open a PR?

[linl33]

Yes, please send a pull request against the development branch.

[adityaofficial10]

@linl33
I've linked the PR.

[wbrunette]

For future reference for someone taking on this issue. Take a look at the previous incomplete PR. odk-x/sync-endpoint-default-setup#26

The comments in the PR give additional direction

[wsmmxmm]

Hi team! I am an outreachy applicant. Please can I work on this issue if it is still open?

[wbrunette]

@wsmmxmm it is still open. I will assign it to you. Check out the PR I commented about as much of the work has been attempted once, just not fully completed.

[Ndacyayisenga-droid]

@wbrunette @linl33 @elmps2018
Can I finish up with this if its still open?
Regards,
Noah

[MariaAngella]

Hello team,

Can I take this on please, I'm an Outreachy applicant.

Thank you and regards,
Maria Angella

[elmps2018]

Hi @MariaAngella! @wsmmxmm is currently assigned but does not look like they worked on it lately. @wbrunette @wsmmxmm is it okay if I reassign?

[wbrunette]

You should first ask the question if they want to have a custom stack name. Because if they change it the directions will not match. So really it's two questions.

[MariaAngella]

Thank you for this assignment.