-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RotatedJsonFileSink? #637
Comments
Hey, At the moment, I don't have plans to implement a RotatedJsonFileSink, but it's an interesting idea, and I’ll definitely give it some thought. Typically, rotation isn’t implemented for JSON sinks because these logs are often parsed and forwarded to a UI by log agents (like Fluentd, Logstash, etc.) For now, if you need this functionality, you can create a custom sink by combining the rotation logic from RotatingFileSink with the JSON formatting logic from JsonFileSink |
To reduce disks pressure we write JSON-formatted logs to in-memory tmpfs with limited size and then forward them by fluentd into permanent UI storage. Being able to automatically rotate logs by size criteria would be a big plus in our case. |
I have added this for v8 release which will be released in about a month. After it is released you can use this example, which is currently in https://github.com/odygrd/quill/blob/v8/examples/rotating_json_file_logging_custom_json.cpp |
Hello! Do you have any plans to implement RotatedJsonFileSink?
The text was updated successfully, but these errors were encountered: