Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: sortable table rows #3

Open
ohbendy opened this issue Jun 4, 2024 · 8 comments
Open

Feature request: sortable table rows #3

ohbendy opened this issue Jun 4, 2024 · 8 comments

Comments

@ohbendy
Copy link
Owner

ohbendy commented Jun 4, 2024

Some people will want to sort by country, language, perhaps Unicode status.

@sovichet
Copy link
Collaborator

sovichet commented Jun 5, 2024

It can be done with jQuery and this DataTable library. I've tried it, but we have an issue because the first column (Script) does not have enough data. So it will be considered empty.

Here's when sorted by Script.

Screenshot 2024-06-05 at 9 46 37 at night

Here's when searched.

Screenshot 2024-06-05 at 9 45 33 at night Screenshot 2024-06-05 at 9 45 07 at night

@ohbendy
Copy link
Owner Author

ohbendy commented Jun 5, 2024

Thanks for looking at this! I did wonder what would happen with the empty spaces. I'm not sure how to deal with those, it's going to add extra clutter if every script name is repeated for every language, and if we also have to add an 'orthography name' to every language, to be able to sort by orthography, we'll have to invent names for the orthographies that don't really have names. Thoughts?

@sovichet
Copy link
Collaborator

I think this issue has been solved already. Closing now.

@ohbendy
Copy link
Owner Author

ohbendy commented Jul 28, 2024

I noticed we've got the same problem of empty cells when filtering. Here we see Tai Sar is listed under Round Script (reformed) but when we filter and the Shan row is not included, that category disappears. Will that be easier to manage with a .js source instead of .md?

Screenshot 2024-07-28 at 18 55 32

Screenshot 2024-07-28 at 18 52 44

@ohbendy ohbendy reopened this Jul 28, 2024
@sovichet
Copy link
Collaborator

This is from the v2 codebase search/filter. Can you confirm this is correct?

Screenshot 2024-08-20 at 5 36 30 in the afternoon

@ohbendy
Copy link
Owner Author

ohbendy commented Aug 20, 2024

Sorry I see I didn't explain properly. Here's the problem:

Tai Sar appears with various orthographies in the full list before searching:

tai sar yes

But when searching for it, the orthographies disappear because they're on lines that aren't displayed, but we need those to show:

Tai Sar no

@sovichet
Copy link
Collaborator

Ah I see. Technically, in the current data/table, there isn't Long script (traditional) (Lik Hto Ngouk, Lik To Yao), etc. in those rows, so it's not showing. I'd suggest repeating the text for those rows.

Currently, we are grouping the rows by script; if we are to also group them by Orthography and it's happening in all other rows, we can consider updating the code.

@ohbendy
Copy link
Owner Author

ohbendy commented Aug 20, 2024

Right, but also the script isnt repeated in those rows, but it shows when searching. Can't it do the same for orthographies? I don't want to fill up the table with repeated info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants