-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save as / Export #344
Comments
Let's discuss it in the planning -- as any IDE we use a concept of a project (which is not properly indicted via UI yet) so a user saves files within the project. I agree that we need:
|
@roll Let's do that, but in the meantime, please let's also discuss this here so I can gather more info for our call Please, check this PR just in case and for further context. We also talked about this with @guergana and @pdelboca last week. Added them here to see if they have further comments. My thoughts on this:
|
@romicolman |
Hey @roll we discussed this during the planning meeting, but I wanted to add more context. As a data trainer I want to:
After exploring the file and making small changes:
After clicking SAVE AS, I expect to see the window where I can select where to save the file on my computer. And... At this point I think we need a deeper conversation. A non-technical user will be more interested in the tabular data itself: the updated version of the csv or Excel file, for instance. A more technical user would expect the data package: the updated file and the descriptive file. So at this point we can do this:
Something like that... Adding @pdelboca here also to have his insights. |
@romicolman my two cents. Most users are used to the difference between So I think it would be worth to explore the option of having separated buttons for this actions:
|
I agree with @pdelboca here |
Hey! Thanks for your insights! A couple of comments. Let me know what yo think. As a user I expect to see all the Save options all together, so what if the Save as button includes two options: Datapackage/File and we keep the Save as place as it is right now (bottom of the ODE). Export button: similar as Save as, we include two options Datapackage/File. My biggest concern is the space we have right now on the ODE screen, but..this is what we can do. Option 1: we add the Export button in the upper right corner (above the table) after the REDO/UNDO. Drawbacks: I don't like this option a lot because it "breaks" the flow of the other options there and we would have a lot of buttons there (metadata, errors report, redo, undo and the export button). Option 2: since we removed the REVERT option, we can place this button at the bottom of the ODE. It makes more sense. Let me test this with two potential users and I'll get back two you. In the meantime, what do you think of the |
@romicolman Currently, we have two options:
|
I will add some extra info here. Currently the Save As is not working, the form has a wrong validation: Probably related to the changes we did in https://github.com/okfn/opendataeditor/pull/374/files |
@pdelboca Unexpected side effect.. oopsie. Yes it's definitely coming from that change. I thought I had isolated the change. I can fix it this week. We definitely need automated tests to avoid these errors. |
@pdelboca I have created this PR: #399 to fix the issue, if you approve the changes and rebase the current PR on top of that one, you should be able to continue working on this. :D :D |
I'm closing this ticket since we addressed part of the issue here. In addition to that, the stable version of the ODE just kept the SAVE option. |
Problem description
Let's say a user uploads a dataset and then want to export it. She/He/They can then go to the top of the screen and click on SAVE AS. This window will pop-up:
As a user with non-technical background I would expect the ODE to show me the window to select location on my . Is it possible to do this @roll? Also, how is the data save on laptop? Zip file with more than one csv (for tabular data, for example)?
The text was updated successfully, but these errors were encountered: