Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datagrid to help the user read errors - Research #429

Open
romicolman opened this issue Jun 17, 2024 · 4 comments
Open

Improve datagrid to help the user read errors - Research #429

romicolman opened this issue Jun 17, 2024 · 4 comments
Assignees

Comments

@romicolman
Copy link
Collaborator

Problem description

Right now, when the ODE previews the table, the app only indicates row numbers.

Captura de pantalla 2024-06-17 a la(s) 10 51 46 a  m

However, the error report will include the cell location to help the user identify errors. Therefore, we need to incorporate a table header, like the one Datawrapper, for example, has:

Captura de pantalla 2024-06-17 a la(s) 10 57 42 a  m

Is this possible?

@Faithkenny
Copy link
Collaborator

I really like Datawrapper's approach to solving this problem. I'd use it as a starting point

@romicolman romicolman assigned pdelboca and guergana and unassigned pdelboca Jun 17, 2024
@guergana guergana moved this from Backlog to In Progress in ODE: Stable Release Jun 21, 2024
@guergana
Copy link
Collaborator

guergana commented Jun 22, 2024

Hello @romicolman , I have added the column headers and it seems to be working fine, so I think the conclusion is that it can be done 💯 ✨ and we can keep this one for the complete version. You can see in the PR #436 . This PR does not include updating the error reports, though. This PR is only adding the headers. Should we create another issue for updating the error reports to identify the cells by column letter and number, since this is only the research part?

@guergana guergana moved this from In Progress to Code review in ODE: Stable Release Jun 22, 2024
@guergana
Copy link
Collaborator

Hey @romicolman I was just thinking of what happens when there are more than 26 columns ... My example only covers the letters of the alphabet.

Will the column after Z be 'A1' or 'AA' ? Do we have maximum amount of columns that the app supports?

@romicolman
Copy link
Collaborator Author

romicolman commented Jun 24, 2024

Heyyy! Thanks for all the info.

Let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. Since this is a research ticket, I'll create a new one and mention this issue.

Errors report: yes...we need to update that. We are working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants