From 817787917eac86195943f8d220824244708e6f78 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Fri, 11 Oct 2024 22:53:47 +0200 Subject: [PATCH 1/4] Register accepting review --- rfc/1/index.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rfc/1/index.md b/rfc/1/index.md index 06605842..cfa5394a 100644 --- a/rfc/1/index.md +++ b/rfc/1/index.md @@ -118,6 +118,12 @@ This RFC is currently being responded to (R4). - EMBL-EBI - 2024-10-08 - Accept (email) +* - Reviewer + - John Bogovic, Michael Innerberger, Virginia Scarlett + - bogovicj, minnerbe, virginiascarlett + - Janelia + - 2024-10-11 + - [Accept](./reviews/2b/index) ``` ## Overview From d6b9c9a9157965f460d1fc9366dc0ffeba9ed948 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Fri, 11 Oct 2024 22:54:10 +0200 Subject: [PATCH 2/4] Implement suggestions 1 and 2 --- rfc/1/index.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rfc/1/index.md b/rfc/1/index.md index cfa5394a..d0bb2e64 100644 --- a/rfc/1/index.md +++ b/rfc/1/index.md @@ -445,7 +445,7 @@ Where possible, **Reviewers** SHOULD be chosen to represent a cross-section of the community. Which cross-sections are chosen MAY depend on a given RFC but might include geographic distributions, the variety of imaging modalities, and/or programming languages of the expected implementations. An attempt MUST -also be made to select both positive and negative voices from the community. +also be made to select both supporting and dissenting voices from the community. *Editors* and *Reviewers* should proactively disclose any potential conflicts of interest to ensure a transparent review process. @@ -609,7 +609,8 @@ This RFC does not try to define all aspects of the NGFF community process and instead focuses on the most immediate block which covers what is typically thought of as the voting process. By establishing this as a foundation, future RFCs can extend the community process either adding or simplifying structure as -feedback determines. In fact, sections like [“Policies”](#policies) are explicitly intended to be updated to reference future RFCs as they are defined. +feedback determines. In fact, sections like [“Policies”](#policies) are explicitly +intended to be updated to reference future RFCs as they are defined. The following items are therefore considered out of scope for the purposes of this RFC but future work is intended to evolve the community process. From 1f59b90a324532522c74cd40afb1ad5617cfd23b Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Fri, 11 Oct 2024 22:54:38 +0200 Subject: [PATCH 3/4] Fix minor typo --- rfc/1/reviews/2b/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rfc/1/reviews/2b/index.md b/rfc/1/reviews/2b/index.md index 2a8b657a..91d57e71 100644 --- a/rfc/1/reviews/2b/index.md +++ b/rfc/1/reviews/2b/index.md @@ -20,7 +20,7 @@ Most of the present reviewers feel that the proposed review process remains over Nevertheless, even though the reviewers feel that the proposal still requires major changes, they change their recommendation to 'accept', acknowledging the importance of forward progress. As the OME-Zarr community moves forward using this proposed process, the reviewers hope that their concerns will be kept in mind and revisited if / when these concerns become practical issues. -Below are some minor changes the author may consider. If the author chooses not implement them, the reviewers will not contest that decision. +Below are some minor changes the author may consider. If the author chooses not to implement them, the reviewers will not contest that decision. ## Suggested Minor Changes From 335df5b04a1338b55cf7b00e987c6a6e8dc9f5ae Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Fri, 11 Oct 2024 22:54:48 +0200 Subject: [PATCH 4/4] Adopt RFC-1 --- rfc/1/index.md | 2 +- rfc/listing.csv | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rfc/1/index.md b/rfc/1/index.md index d0bb2e64..3196278b 100644 --- a/rfc/1/index.md +++ b/rfc/1/index.md @@ -15,7 +15,7 @@ versions/index ## Status -This RFC is currently being responded to (R4). +This RFC has been adopted (S4). ```{list-table} Record :widths: 8, 20, 20, 20, 15, 10 diff --git a/rfc/listing.csv b/rfc/listing.csv index c8b2800c..24166b5d 100644 --- a/rfc/listing.csv +++ b/rfc/listing.csv @@ -1,6 +1,6 @@ RFC,Description,Date,Status [0](0/index.md),Original consensus model for decision making,2021,N/A -[1](1/index.md),RFC Process,2024,Under review +[1](1/index.md),RFC Process,2024,Adopted [2](2/index.md),Zarr V3 Support,2024,Accepted 3,Remove axis restrictions,2024, Clarifications [4](4/index.md),Axis Anatomical Orientation,2024,Under review