Testing

[sharonmleon]

Please test the Omeka Classic version of Freedom, paying special attention to the configuration options and some of the more popular plugins: (Exhibit Builder, Simple Pages, Geolocation, Contribution, Collection Tree, SimpleVocab, Search By Metadata).

[katknow]

I'm not sure what the line is for in front of the footer content:

I notice there are two lines when there nav bar is also being shown, so I wonder if it has something to do with that.

I'm filling in the the "Recent Records" section but nothing seems to be happening.

When all of the "Records Tags" are unchecked all tags disappear, yet regardless of what is checked all three kinds of tags appear.

The spacing seems a bit off on the Contribution page, especially between the "Browse" button and "Title":

I tried to install Simple Vocab to test, but I can't get it to appear in the menu.

Exhibit Builder, Simple Pages, Geolocation, Collection Tree all seem to be working fine and look okay.

[allanaaa]

I'm not clear on the logo instructions (210x60px). That's only for when the menu and logo are inline, right? I wonder if we can toggle the interface instructions based on that dropdown selection.

I'm not sure the banner recommendation (1280x560) is great either. Surely we want people to upload wider images that won't get stretched when the browser window is wider than 1280?

Note also that the default footer text is "Powered by Omeka S" 😬

I would include some explanatory text about the footer layout - "Content will appear in 1, 2, or 3 columns with dividing lines depending on how many of the following fields you use" or something.

[allanaaa]

The menu, when full-width, has these focus underlines that are just a bit off to me.

When a menu item is two lines of text, the line goes across the full width of the li.

But when a menu item is one line, it just shows up like an underline on the text (i.e. it's not the full width of the li).

Can we make these match, one way or the other?

[allanaaa]

Can you also add a nicer default styling for the site title when no logo is being used?

Even just using h1 would be good, I think.

[allanaaa]

The image derivatives you're showing on the browse pages look really fuzzy. My square thumbnails are set to 200x200, and you're displaying 312x312 or something. Is there a setting to change that? I see they do resize a small amount when the window resizes, but I don't want to see anything stretched up at all.
I realize I could resize all my thumbnails for use on this site, but that seems drastic. Or at least we should include instructions on how to do that, whatever the maximum size is that you might want to display.

[sharonmleon]

@nelsonamaya82 I assigned you to this issue and added you to the Team Omeka core, so you should now be getting alerts.

[allanaaa]

Can you turn off the "Item" tag that shows on the Browse Items page? Ditto the "Collection" that shows on the Browse Collections page.'

[allanaaa]

Also we should probably limit the number of tags that show on the Browse pages, some of them have A LOT.

[nelsonamaya82]

@katknow I tested the "Recent Records" section and it works fine, here's a screenshot:

I installed the Simple Vocab plugin and it works fine, I can see it in the menu:

@allanaaa the logo instructions (210x60px) are general, no matter the header layout. Anyway this is just a recommended size).

Fuzzy images: I was using th wrong image size but it's fixed now. It looks way better.
Limit the number of tags: I added a new option to the Theme Settings page in order to set the max number of tags to display. In case an item has more tags than the max number, there will be a link "...more" next to the tags to indicate the user there are more (hidden) tags. When clicked, it should go to the record show page and scroll automatically to the "Tags" section, where the user can see all the tags:

@katknow @allanaaa the rest of the issues you reported are already fixed and merged into the master branch. Feel free to retest and let me know if you see any other issues.

Thanks!!

[allanaaa]

I'm getting this when I have multiple levels of menu items:

Screen.Recording.2023-12-19.at.14.22.41.mov

[allanaaa]

The advanced search page seems to have slightly different padding than the other pages:

Screen.Recording.2023-12-19.at.15.11.01.mov

[allanaaa]

Also, the Contribution page (from the Contribution plugin) is also misaligned compared to other pages. I imagine this is just a form padding issue.

http://dev.omeka.org/amayer/amayer-c/omeka/contribution

But Contact Us (from the Simple Contact Form plugin) looks fine:

http://dev.omeka.org/amayer/amayer-c/omeka/contact

[allanaaa]

On a collections page like this:

http://dev.omeka.org/amayer/amayer-c/omeka/collections/show/99

What determines how many items are shown? I can't count how many are on this page but it would be nice to cut it off at 10-20.

[allanaaa]

For collections that are hierarchical using the Collection Tree plugin, I wonder if the collection view page could show the bullet list of subcollections higher up? That might be a plugin question instead of a theme question. I'm not sure how we do it on other themes.

http://dev.omeka.org/amayer/amayer-c/omeka/collections/show/1

[katknow]

Recent Records is now working fine for me as well, so not sure what the issue was before.

I will say that I'm not having the same menu issue if that helps narrow down potential problems.

My collections do seem to be cutting off at 10 with a "View all X items" link at the bottom.

However, on the browse collections page I'm now having a problem where one of the containers goes down into the buttons to tab between pages:

This is issue is not replicated on any of my other browse pages.

[nelsonamaya82]

@allanaaa:

• The Advanced Search page doesn't have a different padding, but the main container is narrower intentionally in order to keep both the page title and the form aligned (as the form is narrower than the default content). This is how it looks like on a bigger screen:

Browse-Items-.-Freedom-Classic-Theme.mp4

Same case with Contribution page. However I think the Contact Us page should be narrower, just like the other form pages (Advanced Search and Contribution). In general terms, narrower forms are more user friendly, but please let me know your thoughts.

• What determines how many items are shown? I'm not really sure as I can't find any code in the frontend related to this quantity in this specific page, I think it's something from the backend. The page you sent as an example has 50 items. Please check in the dashboard, under Appearance -> Settings how many items you have in "Results Per Page". That's the only field that comes to my mind that might control that. If not, I'd have to ask Jim or John.

• For collections that are hierarchical using the Collection Tree plugin, this functionality comes directly from the plugin. It works like this on other themes too.

The rest of the issues are fixed and merged into the master branch.

@katknow the screenshot you sent is from a local environment? It seems like it's not properly built as I don't see the buttons icons and the menu items text are not correctly aligned (they should be vertically centered). If it's from a local site, please pull the master branch again and build the theme assets.

[allanaaa]

In general terms, narrower forms are more user friendly, but please let me know your thoughts.

I want the page title to be in the same spot on every page, rather than aligned with the content. Happy to be outvoted on this, though, if anyone else wants to chime in.

That's the only field that comes to my mind that might control that. If not, I'd have to ask Jim or John.

If you could make that a separate setting, or just hard-code it down to fewer, that would be great. I have it at 50 for "browse items" and "browse collections" results per page, but when looking at a collection's view page by itself, I would want that way lower, since you can then link to see the results on their own.

[allanaaa]

Thank you for fixing the menu! Looks great.

[nelsonamaya82]

@allanaaa I've just pushed the adjustment to the title alignment to the master branch.

So this is how it looked like before:

and this how it's now:

Regarding the custom number of items in a collection show page, I talked with John and we'll check the option to put this in the core's appearance settings so you just could always set it and it would apply for every theme (it's better to not work around it in the theme but do it in the core so it's there in a newer release). I'll keep you posted on this.

[nelsonamaya82]

@allanaaa @katknow please let me know if you found anything else, or if you think we're ready to release this theme. Thanks!

[nelsonamaya82]

@allanaaa the option to set a custom number of items in a collection show page will be addressed here: omeka/Omeka#1016

[allanaaa]

Looks great, I'm just going to look at it on my phone.

[allanaaa]

It really looks fantastic on mobile, I'm happy to see this released.

One thing that you can mull over at your leisure, no rush for this release and might necessitate a new release for S as well - can we give users two colour choices in the theme settings? So they can change the dark blue footer / nav colour, in future releases?

[nelsonamaya82]

Thanks @allanaaa and @katknow, sounds good! I'll start working on the release. And yes, adding the option to select the dark color sounds like a good addition to the themes, I'm creating a ticket to add it later.