Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can a workflow template name be taken by a workspace template? #256

Open
rushtehrani opened this issue May 25, 2020 · 3 comments · May be fixed by #746
Open

Can a workflow template name be taken by a workspace template? #256

rushtehrani opened this issue May 25, 2020 · 3 comments · May be fixed by #746
Labels
kind/bug Something isn't working

Comments

@rushtehrani
Copy link
Contributor

Say I create a workspace template 'zebra' that will create a workflow template with the same name right?

So I can't go to workflow templates and create zebra and it will tell me it's already taken.

Should this happen, or should we indicate where the name is taken from somehow?
@rushtehrani
Copy link
Contributor Author

This is a good point, it's probably best to prefix all system workflow templates with a sys-

@rushtehrani rushtehrani added this to the v0.10.0 milestone May 25, 2020
@rushtehrani rushtehrani modified the milestones: v0.11.0, v0.12.0 Jun 2, 2020
@rushtehrani rushtehrani modified the milestones: v0.11.0, v0.12.0 Jul 1, 2020
@rushtehrani rushtehrani modified the milestones: v0.12.0, v0.14.0, v0.13.0 Sep 4, 2020
@rushtehrani rushtehrani modified the milestones: v0.13.0, v0.14.0 Sep 16, 2020
@rushtehrani rushtehrani added the kind/bug Something isn't working label Sep 21, 2020
@rushtehrani rushtehrani modified the milestones: v0.14.0, v0.15.0 Oct 23, 2020
@rushtehrani rushtehrani modified the milestones: v0.15.0, v0.16.0 Nov 9, 2020
@Vafilor
Copy link
Contributor

Vafilor commented Nov 25, 2020

Just tested this, and it is still an issue.

@rushtehrani In addition to adding the sys- prefix, should we restrict template names from starting with sys- so if you try to make a template with the name of sys-aardvark it'll return a 400 - saying sys- names are reserved?

@rushtehrani
Copy link
Contributor Author

@rushtehrani In addition to adding the sys- prefix, should we restrict template names from starting with sys- so if you try to make a template with the name of sys-aardvark it'll return a 400 - saying sys- names are reserved?

@Vafilor Yes, sys- prefix is reserved.

@Vafilor Vafilor linked a pull request Nov 25, 2020 that will close this issue
Open
3 tasks
@rushtehrani rushtehrani modified the milestones: v0.16.0, v0.17.0 Dec 3, 2020
@rushtehrani rushtehrani modified the milestones: v0.16.0, v0.17.0 Dec 11, 2020
@rushtehrani rushtehrani modified the milestones: v0.17.0, v0.18.0 Jan 5, 2021
@rushtehrani rushtehrani removed this from the v0.18.0 milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reserved system name checks when creating templates Vafilor/core
2 participants
@rushtehrani @Vafilor