You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually it's two separate issues but I'll put them in single report since they're about same feature.
First "Light Number" as in web interface or "LED number" as in raspberry screen menu are misleading because they don't refer to an LED number on a strip but to a key number on a piano.
Second and more important this magic number 20 note_pos_raw = int(density * (note - 20) - note_offset)
seems to move position of the offset from actual note number to note - 20 which greatly complicates offset configuration.
Installation Method
For installation I used prebuilt image version 1.5 from Releases page and saved it to SD card using Etcher.
Steps to Reproduce
Create new offset
Set Light Number to any number written on LED strip and any Offset. For example 56 and 2
All LEDs starting from key 36 are shifted 2 lights to left
Expected behavior
Expected to see LEDs starting from LED labeled 56 to move 2 lights left.
Environment
I'm using WS2812B strip and Casio CDP-S110BK piano.
The text was updated successfully, but these errors were encountered:
Hello.
I think I’ll just change the naming from 'Light number' to 'Note number' to make it less confusing. That way, you’ll still set the offset relative to the piano key, not the LED strip itself. I’ll also remove the '20' offset in the frontend, so you can simply type the note’s number, counting from the left. It will still be confusing on pianos with fewer than 88 keys, but that’s what the green and red alignment lights are for.
Actually it's two separate issues but I'll put them in single report since they're about same feature.
First "Light Number" as in web interface or "LED number" as in raspberry screen menu are misleading because they don't refer to an LED number on a strip but to a key number on a piano.
Second and more important this magic number 20
note_pos_raw = int(density * (note - 20) - note_offset)
seems to move position of the offset from actual note number to note - 20 which greatly complicates offset configuration.
Installation Method
For installation I used prebuilt image version 1.5 from Releases page and saved it to SD card using Etcher.
Steps to Reproduce
Expected behavior
Expected to see LEDs starting from LED labeled 56 to move 2 lights left.
Environment
I'm using WS2812B strip and Casio CDP-S110BK piano.
The text was updated successfully, but these errors were encountered: