Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp on participant version history is very weird #414

Open
biblicabeebli opened this issue Feb 5, 2025 · 0 comments
Open

timestamp on participant version history is very weird #414

biblicabeebli opened this issue Feb 5, 2025 · 0 comments
Assignees
Labels
Bug Sounds like a bug!

Comments

@biblicabeebli
Copy link
Member

Foundi it!

  • We are using the old version values when we create a new app version history event, so the time recorded is the time that they CHANGED AWAY FROM the version listed.

## App and OS version tracking
# get the existing version code info
prior_version_code = participant.last_version_code
prior_version_name = participant.last_version_name
prior_os_version = participant.last_os_version

# attribute is updated in update_only
if (prior_version_code != participant.last_version_code or
prior_version_name != participant.last_version_name or
prior_os_version != participant.last_os_version):
# log(f"os version changed: {last_version_code} to {session_participant.last_version_code}")
participant.generate_app_version_history(
prior_version_code, prior_version_name, prior_os_version
)

That's very silly, fix:

  • The field currently in use to identify this one is the created on date
  • this has a last updated field
  • so we can transition this to "date of upgrade" by creating a new timestamp field, populating it from the history, and just creating an entry for the current version.
  • (and last updated differing from created_on becomes an indicator that it was migrated)

Question: is anyone using this api endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Sounds like a bug!
Projects
None yet
Development

No branches or pull requests

6 participants