From b777f59bb588be90656ce1b872591260a153fcda Mon Sep 17 00:00:00 2001
From: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Date: Fri, 4 Oct 2024 10:31:05 +0200
Subject: [PATCH] fix: push access to packages (#530)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Description

<!--
Please do not leave this blank
This PR [adds/removes/fixes/replaces] the [feature/bug/etc].
-->

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.


## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Related Tickets & Documents

<!--
Please use this format link issue numbers: Fixes #123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
- Related Issue # (issue)
- Closes # (issue)
- Fixes # (issue)
> Remove if not applicable

## Screenshots

<!-- Visual changes require screenshots -->


## Added tests?

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
- [ ] Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration


## Added to documentation?

- [ ] 📜 README.md
- [ ] 🙅 no documentation needed

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
---
 .github/workflows/components_push.yaml | 3 ++-
 .github/workflows/release.yaml         | 8 ++------
 docs/release_notes/v0.24.10.md         | 3 +++
 pkg/version/release.go                 | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
 create mode 100644 docs/release_notes/v0.24.10.md

diff --git a/.github/workflows/components_push.yaml b/.github/workflows/components_push.yaml
index 3c63c502..8a0f1235 100644
--- a/.github/workflows/components_push.yaml
+++ b/.github/workflows/components_push.yaml
@@ -7,6 +7,7 @@ on:
 permissions:
   contents: read
   pull-requests: read
+  packages: write
 
 jobs:
   build-cli:
@@ -36,4 +37,4 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           cd component/
-          PATH=$PATH:$(go env GOPATH)/bin make ocm && make ctf && make push
\ No newline at end of file
+          PATH=$PATH:$(go env GOPATH)/bin make ocm && make ctf && make push
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 292a9fac..9f2642cb 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -23,8 +23,9 @@ jobs:
     name: Component CTF Builds
     uses: ./.github/workflows/components_push.yaml
     permissions:
-      contents: read
+      contents: write
       pull-requests: read
+      packages: write
   release:
     needs: tests
     name: Trigger release build
@@ -120,8 +121,3 @@ jobs:
         helm registry login ghcr.io -u open-component-model -p ${{ secrets.GITHUB_TOKEN }}
         helm package --version ${{ env.RELEASE_VERSION }} --app-version ${{ env.RELEASE_VERSION }} ./deploy
         helm push ${{ github.event.repository.name }}-${{ env.RELEASE_VERSION }}.tgz oci://ghcr.io/open-component-model/helm
-    - name: Push OCM Components
-      env:
-        GITHUBORG: ${{ github.repository_owner }}
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      run: make plain-push
diff --git a/docs/release_notes/v0.24.10.md b/docs/release_notes/v0.24.10.md
new file mode 100644
index 00000000..a8b63cbe
--- /dev/null
+++ b/docs/release_notes/v0.24.10.md
@@ -0,0 +1,3 @@
+# Release 0.24.10
+
+- fix: permissions issue for pushing into packages
diff --git a/pkg/version/release.go b/pkg/version/release.go
index 3dd1beae..e90d9648 100644
--- a/pkg/version/release.go
+++ b/pkg/version/release.go
@@ -5,7 +5,7 @@
 package version
 
 // ReleaseVersion is the version number in semver format "vX.Y.Z", prefixed with "v".
-var ReleaseVersion = "v0.24.9"
+var ReleaseVersion = "v0.24.10"
 
 // ReleaseCandidate is the release candidate ID in format "rc.X", which will be appended to the release version.
 var ReleaseCandidate = "rc.1"