Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORD-4.1] Create Dataset from File #118

Closed
2 of 3 tasks
yauhen-karmyzau opened this issue Jan 7, 2025 · 3 comments
Closed
2 of 3 tasks

[ORD-4.1] Create Dataset from File #118

yauhen-karmyzau opened this issue Jan 7, 2025 · 3 comments
Assignees
Labels
Front-end Ticket for front-end development. test-cases-written Test cases are ready and added to .xls file tested-locally Tested by QA on local environment

Comments

@yauhen-karmyzau
Copy link

yauhen-karmyzau commented Jan 7, 2025

@yauhen-karmyzau yauhen-karmyzau added this to the Dataset creation milestone Jan 7, 2025
@yauhen-karmyzau yauhen-karmyzau added the Front-end Ticket for front-end development. label Jan 7, 2025
@yketov yketov changed the title [ORD-4.1] Create dataset from the file [ORD-4.1] Create Dataset from File Jan 13, 2025
@Albina-J
Copy link

Albina-J commented Jan 16, 2025

@ivanmaslow @daniil-sloboda

Question Answer
Clarify if we should allow the old file formats (.pb, .pbtxt) to be uploaded as well besides new ones ( .binpb, .txtpb, .json)? Note: .pb - works if renamed to .binp but txt does not work ORD: Not high priority feature and can be pushed to later - but it is good to allow users to work with old formats. If it is easy to implement - add old formats.

@ivanmaslow ivanmaslow added test-cases-written Test cases are ready and added to .xls file tested-locally Tested by QA on local environment labels Jan 20, 2025
@Albina-J
Copy link

  1. Dataset name / details character limit
  2. Dataset size limit

@ivanmaslow
Copy link

ivanmaslow commented Jan 22, 2025

The feature is tested on a local environment with the latest commit 98df274, retesting is required after implementation of reactions, points below are covered:

  • Verify UI elements for the "From File" uploading option, including button icon, file name, and description
  • Verify UI elements for the "From File" pop up, including name of pop up and fields: Group and Dataset file
  • Verify that the "Group" field is required and that clicking on it opens a list of created groups
  • Verify the "Dataset file" field is required, shows formats (.binpb, .txtpb, .json) below, and opens a file selection pop-up with these extensions
  • Verify that users can upload all valid formats (.binpb, .txtpb, .json, .pb, .pbtxt) to the appropriate group and that they are displayed on the contribute page
  • Verify that after uploading of dataset, dataset view is opened
  • Verify that loading icon is displayed when uploading file
  • Verify that users cannot upload invalid formats, ensuring an error message is returned in the API response and displayed in the UI
  • Verify that name and description fields has limit for characters
  • Verify different fields on uploading (for name/description/reactionId - empty/not presented)

Several issues are detected based on failed tests:

TBD tasks that requires retesting:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front-end Ticket for front-end development. test-cases-written Test cases are ready and added to .xls file tested-locally Tested by QA on local environment
Projects
None yet
Development

No branches or pull requests

4 participants