Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaction card URLs #97

Open
1 of 2 tasks
skearnes opened this issue Jan 29, 2024 · 6 comments
Open
1 of 2 tasks

reaction card URLs #97

skearnes opened this issue Jan 29, 2024 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@skearnes
Copy link
Member

skearnes commented Jan 29, 2024

  • The publication URL link doesn't seem to point to the publication URL?
  • The dataset ID should be a link to a query for that dataset.
@skearnes skearnes added bug Something isn't working enhancement New feature or request labels Jan 29, 2024
@miori-nd miori-nd self-assigned this Jan 30, 2024
@miori-nd
Copy link
Collaborator

I'd like to work on these

@bdeadman
Copy link
Collaborator

bdeadman commented Feb 1, 2024

@miori-nd I've found another dataset url issue which is potentially related, or maybe something to push to a separate issue.

Links to ORD datasets have been published in articles about ORD but these links are now broken after changes to the ord-interface. We have several example datasets linked in the JACS paper.

The old link is going to:
https://client.open-reaction-database.org/id/ord-00b28c352e6a453398fad16ac35a55c6

but it should point to:
https://open-reaction-database.org/id/ord-00b28c352e6a453398fad16ac35a55c6

How feasible is it to include a redirect in the ord-interface so if someone accesses an old dataset link it pushes through to the correct location?

@miori-nd
Copy link
Collaborator

miori-nd commented Feb 1, 2024

@bdeadman Thank you for reporting that, we should be able to provide a redirect since both of the links are going to the same domain (open-reaction-database.org) just a different subdomain (the subdomain is the "client." part). I will make a separate issue for that and link it here for tracking purposes.

@miori-nd
Copy link
Collaborator

miori-nd commented Feb 1, 2024

@skearnes Could you provide an example of a broken publication link on production? It seems to me that that might be a data quality issue on specific publication links that happen to be broken. The ones in the test database seem to be working fine in the interface (I am working out of the vue branch though so maybe that's out of sync with what's on production)

@skearnes
Copy link
Member Author

@skearnes Could you provide an example of a broken publication link on production? It seems to me that that might be a data quality issue on specific publication links that happen to be broken. The ones in the test database seem to be working fine in the interface (I am working out of the vue branch though so maybe that's out of sync with what's on production)

https://open-reaction-database.org/search?dataset_ids=ord_dataset-4e9c2fa02a7544fd839206719263345f&limit=100 the publication URL just links back to the search page

@bdeadman
Copy link
Collaborator

The client.open-reaction-database redirect works.

Still to do:

DOI to be turned into the publication URL link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants