Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test button (DO NOT MERGE) #78

Closed
wants to merge 8 commits into from

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 20, 2023

Description

This is just a test to see if Michael's cheatsheet for the edit button works

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Relates to #75

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@CBID2 CBID2 requested a review from BekahHW October 20, 2023 00:08
@netlify
Copy link

netlify bot commented Oct 20, 2023

βœ… Deploy Preview for sauced-intro ready!

Name Link
πŸ”¨ Latest commit 7edbd6f
πŸ” Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/653fc50b3a8fdb00082e4843
😎 Deploy Preview https://deploy-preview-78--sauced-intro.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2 CBID2 self-assigned this Oct 20, 2023
@adiati98
Copy link
Member

adiati98 commented Oct 20, 2023

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page β€” (Edit this page on GitHub πŸ“). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 20, 2023

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page β€” (Edit this page on GitHub πŸ“). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md#

@adiati98
Copy link
Member

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page β€” (Edit this page on GitHub πŸ“). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md#

We can try it first. If it doesn't work, then we can let it go 😊

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 20, 2023

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page β€” (Edit this page on GitHub πŸ“). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md#

We can try it first. If it doesn't work, then we can let it go 😊

I tried it and it did not work lol πŸ˜‚

@adiati98
Copy link
Member

adiati98 commented Oct 20, 2023

@CBID2 lol πŸ˜†
Well, let's do it your way, then πŸ˜„
Just put the icon on the left side.

Maybe the pencil or pen icon looks similar? ✏️ πŸ–Š

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 20, 2023

✏️

Made the change @adiati98. Here's how it looks:
edit this page example

@adiati98
Copy link
Member

It looks much better, @CBID2!

As for the link, let's make it similar with our docs. If you click the "Edit this page" link, it will bring user to the editing page.

So we want to navigate to the edit page such as this one for the intro instead of the blob.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 22, 2023

It looks much better, @CBID2!

As for the link, let's make it similar with our docs. If you click the "Edit this page" link, it will bring user to the editing page.

So we want to navigate to the edit page such as this one for the intro instead of the blob.

Hi @adiati98. I made the change! :) @BekahHW, I think this is how we should put the edit "buttons" for now and then come back to it in the future.

@BekahHW
Copy link
Member

BekahHW commented Oct 30, 2023

@CBID2 sounds good to me. Are you going to put that on all the pages?

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 30, 2023

@CBID2 sounds good to me. Are you going to put that on all the pages?

Yes @BekahHW

@CBID2 CBID2 closed this Oct 30, 2023
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 30, 2023

Hey @BekahHW. I made the changes on PR #75, so I closed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants