-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add test button (DO NOT MERGE) #78
Conversation
β Deploy Preview for sauced-intro ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @CBID2, I've checked this out :)
|
@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md# |
We can try it first. If it doesn't work, then we can let it go π |
I tried it and it did not work lol π |
@CBID2 lol π Maybe the pencil or pen icon looks similar? βοΈ π |
Made the change @adiati98. Here's how it looks: |
It looks much better, @CBID2! As for the link, let's make it similar with our docs. If you click the "Edit this page" link, it will bring user to the editing page. So we want to navigate to the edit page such as this one for the intro instead of the blob. |
Hi @adiati98. I made the change! :) @BekahHW, I think this is how we should put the edit "buttons" for now and then come back to it in the future. |
@CBID2 sounds good to me. Are you going to put that on all the pages? |
Description
This is just a test to see if Michael's cheatsheet for the edit button works
What type of PR is this? (check all applicable)
Related Tickets & Documents
Relates to #75
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?