Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile in directory #86

Closed
wants to merge 1 commit into from
Closed

Conversation

Adidem23
Copy link

I have Added Docker File in the repository according to issue #82

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

I have added docker image named openpizza and we have to give command

  • Command to run docker image : docker run -it -p 8000:8000 openpizza in vs code or any terminal will serve image on port 8000

##Recordings
https://www.loom.com/share/7d30a814149149918f907783dc4a8cd2?sid=687947ac-1622-47fe-90a4-d9d581ef54c8

Added tests?

  • πŸ‘ yes

  • πŸ™… no, because they aren't needed

  • πŸ™‹ no, because I need help

  • πŸ“œ README.md

  • πŸ““ docs.opensauced.pizza

  • πŸ• dev.to/opensauced

  • πŸ“• storybook

  • πŸ™… no documentation needed

@netlify
Copy link

netlify bot commented Oct 26, 2023

βœ… Deploy Preview for sauced-intro ready!

Name Link
πŸ”¨ Latest commit 4978402
πŸ” Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/653a7825c2a2d70008ce51ff
😎 Deploy Preview https://deploy-preview-86--sauced-intro.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adiati98 adiati98 mentioned this pull request Oct 30, 2023
2 tasks
@adiati98
Copy link
Member

adiati98 commented Oct 30, 2023

Hi @Adidem23,
Thank you for your patience.

We've talked about this internally.
Because this project doesn't have complex setup and installation, and most of content in this repo are in Markdown, we don't think that Docker approach would be helpful here.

That said, we're closing your PR and closes issue #82 .
However, we appreciate your ideas. Thank you. :)

@adiati98 adiati98 closed this Oct 30, 2023
@Adidem23
Copy link
Author

Bad 😞 to hear that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants