Have reasonable defaults for the geoipprocessor
's context
and attribute
parameters
#37070
Labels
geoipprocessor
's context
and attribute
parameters
#37070
Component(s)
processor/geoip
Is your feature request related to a problem? Please describe.
As it came out from this discussion the current defaults for the
attributes
parameter of the geoipprocessor are not meaningful, becausecontext
is set toresource
andattributes
is set to[source.address, client.address]
, although these attributes are used to describe spans (i.e. records) and never resources.Describe the solution you'd like
I would change the defaults the following way:
context
would default torecord
, because to me it feels like the primary use case (I think it is seldom that somebody has so many resources that they want to geo code their own IPs, instead of their clients' IPs)attributes
would have a default value based on thecontext
:context
isrecord
, then[source.address, client.address
]context
isresource
, then[host.ip]
Note: these are breaking changes for users, who are relying on default values of these two fields (however, since the default values are not reasonable as discussed above, I don't think that anybody has ever relied on them).
Describe alternatives you've considered
No response
Additional context
The PR #37008 has implemented the
attributes
property in a way that its default value is not dependent on thecontext
property.The text was updated successfully, but these errors were encountered: