-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate support for reading resource-related fields from span attributes #37077
Labels
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think #36924 might be a related issue? |
That issue is concerning the datadogreceiver, which has its own translation logic separate of the one used in the exporter and connector. |
6 tasks
dmitryax
pushed a commit
that referenced
this issue
Jan 15, 2025
#### Description Add a feature gate exporter.datadogexporter.EnableReceiveResourceSpansV2. Enabling this gate uses a refactored implementation of OTLP->Datadog Span translation which improves performance by 10%, and deprecates the following functionality: - No longer checks for resource-related values (container, env, hostname) in span attributes. This previous behavior did not follow the OTel spec. After a migration period of 6 versions, we plan to change this to opt-out, then deprecate the old functionality after another 6 versions. #### Link to tracking issue #37077 #### Testing Add unit tests for new functionality (verify that relevant span attributes aren't used). Ran collector with new feature flag enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
connector/datadog
Describe the issue you're reporting
When transforming an OTLP span to a Datadog span (in either datadogconnector or datadogexporter), the following attributes are read from the OTLP span and used to populate the fields of the Datadog span:
We would like these to be read from resource attributes and only resource attributes. In previous releases, some of these attributes could be set in span attributes as well - however, we are in the process of deprecating that, to match Datadog's specification. This issue is to flag this change and track the deprecation effort.
Tracking work:
We've merged a few PRs to introduce an alternative code path in the Datadog trace agent (which performs trace translation) that deprecates this functionality: see DataDog/datadog-agent#30981
This PR deprecates the functionality for when
connector.datadogconnector.NativeIngest
is enabled. This user who was usingservice.name
in span attributes encountered an issue following this change..In a future PR, we'll add a feature flag which allows users to enable the alternate code path when
connector.datadogconnector.NativeIngest
is disabled as well.The text was updated successfully, but these errors were encountered: