-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load product catalog periodically #1919
Merged
julianocosta89
merged 8 commits into
open-telemetry:main
from
puckpuck:product-catalog.periodic-reload
Jan 28, 2025
Merged
load product catalog periodically #1919
julianocosta89
merged 8 commits into
open-telemetry:main
from
puckpuck:product-catalog.periodic-reload
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
Requires an update to the Helm chart when released
label
Jan 16, 2025
rogercoll
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@rogercoll I made several minor updates to address the comments. Can you review again? |
rogercoll
approved these changes
Jan 27, 2025
julianocosta89
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1892
PRODUCT_CATALOG_RELOAD_INTERVAL
This allows the user to change the products without rebuilding the product-catalog service. The products can also be updated after the demo is running. The change also paves the way for reloading the product catalog on a period timer, allowing the product list to be backed by more dynamic sources such as a database.
Finally, this change will require some updates to the Helm chart to load and mount the product list via a ConfigMap.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.