[OpenTelemetry.Instrumentation.AWSLambda] Do not crash on empty LambdaContext #2457
+51
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.awslambda
Dreamescaper
force-pushed
the
do_not_crash_on_empty_lambda_context
branch
from
ab4e681 to
bf7baf2
Compare
Dreamescaper
force-pushed
the
do_not_crash_on_empty_lambda_context
branch
from
bf7baf2 to
eeb9ec2
Compare
|
Consider adding CHANGELOG entry. |
|
@Kielek |
ppittle
approved these changes
Jan 7, 2025
|
@Dreamescaper - thank you for contributing the fix! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
==========================================
- Coverage 73.91% 0 -73.92%
==========================================
Files 267 0 -267
Lines 9615 0 -9615
==========================================
- Hits 7107 0 -7107
+ Misses 2508 0 -2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2445
Changes
Handle the case is InvokedFunctionArn is null in LambdaContext.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes