We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List
Slice
The specification states this type as ...
An array (a list) of any values
We currently use the term "List" for these value types in the logs bridge API design.
Given Go does not use this term, it seems fitting to call it something more native. Use Slice instead:
const ( KindEmpty Kind = iota // .. KindSlice // ... ) // Value factory: func SliceValue(vs ...Value) Value // Value accessor: func (v Value) AsSlice() []Value // KeyValue factory: func Slice(key string, args ...Value) KeyValue
The text was updated successfully, but these errors were encountered:
I support the proposal. For what I remember the only reasons I decided to call it List were:
I find Slice more accurate and idiomatic
Sorry, something went wrong.
Plan is to wait for #4907 to merge prior to addressing.
I also support the proposal, as we already use the slice term in our kv.go. Using slice can keep consistency.
slice
kv.go
opentelemetry-go/attribute/kv.go
Lines 37 to 40 in 8739674
MrAlias
Successfully merging a pull request may close this issue.
The specification states this type as ...
We currently use the term "List" for these value types in the logs bridge API design.
Given Go does not use this term, it seems fitting to call it something more native. Use
Slice
instead:Alternatives
The text was updated successfully, but these errors were encountered: