Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] Prometheus datasource for dashboards defaults to webstore-metrics #1479

Open
Pionerd opened this issue Dec 28, 2024 · 0 comments
Open
Labels
chart:demo Issues related to opentelemetry-demo helm chart

Comments

@Pionerd
Copy link
Contributor

Pionerd commented Dec 28, 2024

Currently the Grafana dashboards default to the (in my humble opinion) arbitrarily named datasource webstore-metrics. Especially when "bringing your own observability" I would expect this to default to prometheus.

Given not everyone will BYO prometheus, the reason for a unique name is probably to be able to coexist next to another instance.

So moving forward, I suspect the best way is to update the dashboards with a configurable datasource? If agreed, I'll make a PR.

@TylerHelmuth TylerHelmuth added the chart:demo Issues related to opentelemetry-demo helm chart label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:demo Issues related to opentelemetry-demo helm chart
Projects
None yet
Development

No branches or pull requests

2 participants