We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processors
Because BaggageSpanProcessor runs onStart(), newly added included Baggage keys need to be manually added to the current Span.
BaggageSpanProcessor
onStart()
BaggageSpanProcessor should be modified to implement ExtendedSpanProcessor and included baggage keys should be added onEnding().
ExtendedSpanProcessor
onEnding()
No response
The text was updated successfully, but these errors were encountered:
@zeitlinger @MikeGoldsmith any thoughts?
Sorry, something went wrong.
Yes, we should do that
@jameyg42 turns out that this feature request violates best practices - see #1633 (comment)
I therefore propose to close this issue.
Successfully merging a pull request may close this issue.
Component(s)
processors
Is your feature request related to a problem? Please describe.
Because
BaggageSpanProcessor
runsonStart()
, newly added included Baggage keys need to be manually added to the current Span.Describe the solution you'd like
BaggageSpanProcessor
should be modified to implementExtendedSpanProcessor
and included baggage keys should be addedonEnding()
.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: