Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaggageSpanProcessor should use ExtendedSpanProcessor.onEnding() #1632

Open
jameyg42 opened this issue Jan 2, 2025 · 3 comments · May be fixed by #1633
Open

BaggageSpanProcessor should use ExtendedSpanProcessor.onEnding() #1632

jameyg42 opened this issue Jan 2, 2025 · 3 comments · May be fixed by #1633

Comments

@jameyg42
Copy link

jameyg42 commented Jan 2, 2025

Component(s)

processors

Is your feature request related to a problem? Please describe.

Because BaggageSpanProcessor runs onStart(), newly added included Baggage keys need to be manually added to the current Span.

Describe the solution you'd like

BaggageSpanProcessor should be modified to implement ExtendedSpanProcessor and included baggage keys should be added onEnding().

Describe alternatives you've considered

No response

Additional context

No response

@jkwatson
Copy link
Contributor

jkwatson commented Jan 2, 2025

@zeitlinger @MikeGoldsmith any thoughts?

@zeitlinger
Copy link
Member

Yes, we should do that

@zeitlinger
Copy link
Member

zeitlinger commented Jan 8, 2025

@jameyg42 turns out that this feature request violates best practices - see #1633 (comment)

I therefore propose to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants