Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown when -changed even occurs for knob which does not exist #212

Open
tpluscode opened this issue Nov 25, 2024 · 0 comments
Open

Comments

@tpluscode
Copy link

I use the API viewer element like

<api-viewer exclude-knobs="quads" src="./custom-elements.json">
  <template data-element="rdf-editor" data-target="host">
    <rdf-editor></rdf-editor>
  </template>
</api-viewer>

The rdf-element component fires a quads-changed event. Even though the prop is included in exclude-knobs, it still tries to run host.syncKnob and fails with

Uncaught TypeError: Cannot destructure property 'name' of 'changed' as it is undefined.

That is because the value returned from getKnob is { knob: undefined; custom: true }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant