Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading valves at startup does not update pipeline headers #271

Open
Aman-14 opened this issue Sep 24, 2024 · 1 comment
Open

Loading valves at startup does not update pipeline headers #271

Aman-14 opened this issue Sep 24, 2024 · 1 comment

Comments

@Aman-14
Copy link

Aman-14 commented Sep 24, 2024

When loading valves from the valves.json file, the pipeline headers are not updated as expected. Instead, the pipeline.valves are simply assigned without reflecting the changes in the pipeline headers.

Relevant code: main.py, lines 204-53

To resolve this, I believe you need to call await pipeline.on_valves_updated() after loading the valves to ensure the headers are properly set.

@Aman-14
Copy link
Author

Aman-14 commented Sep 24, 2024

I can write a fix for this. Let me know when it's good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant