Archie validator seemingly allows a null TerminologyId.value

[MattijsK]

According to the specs, this should not be allowed. But the validator doesn't seem to check this correctly as we have seen validated RM_OBJECTS where a CodePhrase.terminologyId is an empty object.

[mathijshudepohl]

After some testing in the RmObjectValidatorTest and our own application (created a composition, containing a CodePhrase without a value), I wasn't able to reproduce anything that could cause an empty value for TERMINOLOGY_ID.

The method used for testing:

@Test
public void test() throws IOException, ADLParseException {
    TerminologyId terminologyId = new TerminologyId();
    assertNull(terminologyId.getValue());
    List<RMObjectValidationMessage> messages = validator.validate(terminologyId);
    assertEquals(1, messages.size());

    Archetype archetype = parse("/com/nedap/archie/rules/evaluation/and.adls");
    OperationalTemplate opt = createOpt(archetype);
    List<RMObjectValidationMessage> messages2 = validator.validate(opt, terminologyId);
    assertEquals(1, messages2.size());
}