Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in term binding checking #634

Open
wolandscat opened this issue Oct 13, 2024 · 0 comments
Open

Error in term binding checking #634

wolandscat opened this issue Oct 13, 2024 · 0 comments
Labels

Comments

@wolandscat
Copy link
Member

See here.

This line of code:

                        } else if (AOMUtils.isValidCode(constraintCodeOrPath) &&
                                !terminology.hasCode(constraintCodeOrPath) &&
                                !(archetype.isSpecialized() && flatParent != null && !flatParent.getTerminology().hasCode(constraintCodeOrPath))
                        ) {

incorrectly has a negation of both the final expression and the final term (flatParent.getTerminology()...). The effect of this is that bindings to terms defined in the flat parent (but not locally) are invalid.

Either could be removed, but it would seem more obvious to remove the final !.

Raising here, in case I don't get time to do a PR, since it's quite a bad bug.

@wolandscat wolandscat added the bug label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant