Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On save timer waiting for URL. #4

Open
willwade opened this issue Mar 29, 2017 · 7 comments
Open

On save timer waiting for URL. #4

willwade opened this issue Mar 29, 2017 · 7 comments
Labels

Comments

@willwade
Copy link
Member

Currently, On save, the site gets rebuilt. I wonder if it would be a good idea that after saving the user sees a "please wait" and the code looks to see when the URL live. Once live show the link to redirect them to it. If not "your addition will be live soon. If you don't see it after 24 hours contact us". - not sure if good idea or not?!

@willwade
Copy link
Member Author

Wait on this. Need to think about it!

@hosseinzoda
Copy link
Collaborator

@willwade
We can do that.
For future. I suggest to make the build trigger by time not on save. Like once every hour or 5minutes.

@willwade
Copy link
Member Author

true. I need to figure that out. on the backend..

@willwade
Copy link
Member Author

Just leaving this here as a note. Not sure about the benefits of delaying the auto deploy. It's more a delay of commiting files to the repo which may be better delayed.

@willwade
Copy link
Member Author

@hosseinzoda
Copy link
Collaborator

@willwade
When amount of save increases this will be an issue. So i think we can just add a limit to it.
Or we can make sure only one build is running at a time. (This makes more sense)

@hosseinzoda
Copy link
Collaborator

If there's a way to cancel running build and re-run. We can implement this issue with no problem. (best)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants