Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFT Summary model, incorrect type #1010

Closed
aaronmillisor opened this issue Dec 4, 2023 · 1 comment · Fixed by #1026
Closed

AFT Summary model, incorrect type #1010

aaronmillisor opened this issue Dec 4, 2023 · 1 comment · Fixed by #1026
Assignees

Comments

@aaronmillisor
Copy link

PR#997 (#997) introduced AFT summary 'counters', however they are defined using the type counter64 (which are monotonically incrementing).

        |  +--ro oc-aftsummary:aft-summaries
        |     +--ro oc-aftsummary:ipv4-unicast
        |     |  +--ro oc-aftsummary:protocols
        |     |     +--ro oc-aftsummary:protocol* [origin-protocol]
        |     |        +--ro oc-aftsummary:origin-protocol    -> ../state/origin-protocol
        |     |        +--ro oc-aftsummary:state
        |     |           +--ro oc-aftsummary:origin-protocol?   identityref
        |     |           +--ro oc-aftsummary:counters
        |     |              +--ro oc-aftsummary:aft-entries?   oc-yang-types:counter64
        |     +--ro oc-aftsummary:ipv6-unicast
        |        +--ro oc-aftsummary:protocols
        |           +--ro oc-aftsummary:protocol* [origin-protocol]
        |              +--ro oc-aftsummary:origin-protocol    -> ../state/origin-protocol
        |              +--ro oc-aftsummary:state
        |                 +--ro oc-aftsummary:origin-protocol?   identityref
        |                 +--ro oc-aftsummary:counters
        |                    +--ro oc-aftsummary:aft-entries?   oc-yang-types:counter64

The type for these should probably be changed to something like gauge32 or uint32. BGP reports similar data using uint32.

        |     |  |     |     |  +--ro prefixes
        |     |  |     |     |     +--ro received?              uint32
        |     |  |     |     |     +--ro received-pre-policy?   uint32
        |     |  |     |     |     +--ro sent?                  uint32
        |     |  |     |     |     +--ro installed?             uint32 
        ```
@dplore
Copy link
Member

dplore commented Dec 9, 2023

I agree this should be fixed. I will review in the OC Operators meeting on Dec 12, 2023

@dplore dplore moved this to Todo in OC Operator Review Dec 9, 2023
@dplore dplore self-assigned this Dec 19, 2023
@dplore dplore moved this from Todo to In Progress in OC Operator Review Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants