Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application namespace hardcoded for Kubeflow #617

Closed
bartoszmajsak opened this issue Oct 6, 2023 · 1 comment
Closed

Application namespace hardcoded for Kubeflow #617

bartoszmajsak opened this issue Oct 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bartoszmajsak
Copy link
Contributor

bartoszmajsak commented Oct 6, 2023

Relates to #605

Kubeflow relies on env variables to wire Istio resources together. Namely USE_ISTIO=true will enable Istio-specific logic but it also needs ISTIO_GATEWAY set in a form of namespace/gateway-name. Currently this is hardcoded to opendatahub/odh-gateway, but we should be able to change namespame name based on DSCInitializationSpec.ApplicationName.

In the v1 plugin this is done by overwriting ossm.env cached file in the service-mesh overlay before kustomize applies manifests.

It is introduced in opendatahub-io/kubeflow#96, now in https://github.com/opendatahub-io/kubeflow/pull/172/files#diff-19e9e6ace6726a23c7e0ae0fe3cf34db0c15e47ef53e5ac9a25488d43a514b55

v2 could follow the same approach in the workbenches.go. Some other components like the dashboard are doing string replacements in files - this can be re-used.

@bartoszmajsak
Copy link
Contributor Author

Fixed in 724837d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Status: No status
Status: Done
Development

No branches or pull requests

2 participants