Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: use ccache and cache action #146

Open
dtrifiro opened this issue Sep 30, 2024 · 1 comment
Open

gha: use ccache and cache action #146

dtrifiro opened this issue Sep 30, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@dtrifiro
Copy link
Contributor

In #145 we started using the cache action to speed up builds by caching the python virtual environments in .nox.

Even though the CPU build is quite fast, we could speed this up even further by installing ccache and caching /root/.cache/ccache before actually building/installing vllm.

@dtrifiro dtrifiro added good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request labels Sep 30, 2024
@dtrifiro
Copy link
Contributor Author

dtrifiro commented Oct 9, 2024

This was (partially) implemented in #147.

The issue with this implementation (and in #145 's) as well, is that all three workflows use the same cache key, meaning there is contention between the three jobs for the cache key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant