-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting Toolbar Blocking Text Input #1636
Comments
After looking at this, I think the bug is actually a bit different: the formatting toolbar is only supposed to be shown above the answer fields when some text in the answer field is selected (I think), but it's also showing when the user focuses on the field and it has no text at all (and no selection). A simple fix would be ensuring that it only appears if some text is selected, not when the field is empty. In that case, it already appears in the correct position: Does that make sense? Or should it appear even when no text is selected, but just higher up? |
Hmm, are answers allowed to contain bulleted lists, images, and other stuff? Then I guess we do need the toolbar visible. I'll see if I can just move it up. |
I don't know that we want that to be visible all the time IMO - Having this appear only on highlight seems like a fine solution for now - @bradenmacdonald. I think the formatting being visible on each visually complicates this editing a fair bit when I expect formatting to be rare |
@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox |
@edschema I agree it's not ideal, but I was asked to leave the image tool in for now, on this thread: https://openedx.slack.com/archives/CR0UMU0QP/p1738366344282679 Unfortunately there aren't a lot of options for improving this without a major change. |
@bradenmacdonald sounds good on leaving the image tool/table option for now. Is there a simple fix to moving the toolbar placement so it's not blocking the text entry box? |
@edschema Unfortunately not that I could find. That's actually how it was designed as you can see here if you create a blank line in the demo editors. Though obviously their design doesn't seem to account for the fact that editors may be only 1 line tall. |
Yeah. Limitations of the editor we're using for now (TinyMCE) mean that we're limited to minor tweaks unless we want to embark on a substantial project. |
The formatting toolbar blocks text entry boxes for Hints and Answers in the problem editor. This happens when creating a problem block in both a library and within a course.
@bradenmacdonald
The text was updated successfully, but these errors were encountered: