Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchability of UPLOAD_FILE_MAX_SIZE #1661

Open
MuPp3t33r opened this issue Feb 17, 2025 · 1 comment
Open

patchability of UPLOAD_FILE_MAX_SIZE #1661

MuPp3t33r opened this issue Feb 17, 2025 · 1 comment

Comments

@MuPp3t33r
Copy link

MuPp3t33r commented Feb 17, 2025

Hi all, so sorry if I've logged this to the wrong place, or I'm being an idiot and there is a way to do this that I'm completely missing

In frontend-app-authoring/src/constants.js#L55 we have a constant "UPLOAD_FILE_MAX_SIZE = 20 * 1024 * 1024"

Insofar as I've found, there's no way to easily override this value without forking the repo and manually editing this value.
This breaks compatibility of the legacy patch (without MFE)

Is it possible that a patch can be implemented for the override of this value?
Or, perhaps a viable patch option would be to read the value of MAX_ASSET_UPLOAD_FILE_SIZE_IN_MB stored in "cms/envs/tutor/production.py" (already patchable via via the legacy openedx-cms-production-settings) to keep the contentstore.new_studio_mfe.use_new_files_uploads_page consistent with the old patch.

Here is a link to a discussion I opened and my findings
https://discuss.openedx.org/t/correctly-patch-max-asset-upload-file-size-in-mb/14572/5

There was another user who asked an equivalent question here, which I linked back to my above post:
https://discuss.openedx.org/t/max-asset-upload-file-size-in-mb-in-sumac-version/14930

Thanks for your consideration :)

@bradenmacdonald
Copy link
Contributor

Makes sense to me that this should be configurable, either via environment variable or fetching the limit from the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants