-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWPP-4991: Ensure PHP8.3 compatibility. #85
Conversation
b573280
to
aee5f55
Compare
.github/workflows/ci.yml
Outdated
code-sniffer: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
php_version: ["8.1", "8.2"] | ||
php_version: ["8.1", "8.3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 8.2 is dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is irrelevant to test if we support both 8.1 and 8.3.
Need to discuss the phpro/soap-client#445 issue with @ademarco. |
Closed in favor of #87 |
No description provided.