Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement form configuration for the footer block #5

Open
vever001 opened this issue Apr 10, 2019 · 3 comments
Open

Implement form configuration for the footer block #5

vever001 opened this issue Apr 10, 2019 · 3 comments
Labels
question Further information is requested

Comments

@vever001
Copy link

Hello,

It would be nice to have a configuration form for the footer block (oe_corporate_blocks_footer).
For now I implemented template_preprocess_oe_corporate_blocks_footer() on my side to inject the needed variables in custom_footer.

Thanks,
Hervé

@ademarco
Copy link
Member

The corporate block is not supposed to be modified, its whole point is to be the same for everyone, what are your needs specifically? So we can escalate to the product owner.

@vever001
Copy link
Author

vever001 commented Sep 4, 2019

Hi @ademarco
I'm talking about the custom_footer part, which should definitely be customizable.
But the setup ATM is a bit strange to me, the custom_footer var is defined in oe_corporate_blocks here but oe_theme actually overrides the whole template and makes use of the variable.

@AaronGilMartinez
Copy link
Contributor

Hello @vever001, this issue still applies? If not, you can close the ticket, thanks.

@AaronGilMartinez AaronGilMartinez added the question Further information is requested label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants