Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework class naming #141

Open
pfrenssen opened this issue Jun 26, 2020 · 0 comments
Open

Rework class naming #141

pfrenssen opened this issue Jun 26, 2020 · 0 comments
Milestone

Comments

@pfrenssen
Copy link
Member

The project has adopted the practice from Symfony to prefix abstract classes with Abstract... but this has no value outside of the Symfony ecosystem and has a number of drawbacks:

  • It is confusing for non-Symfony developers.
  • It is providing redundant information.
  • It causes related files to no longer be grouped together in directory listings.

Let's rename them to follow this standard:

  • If the abstract class is intended as a starting point for a group of classes that implement a certain interface then we consider this as a "base class" and we add the suffix ...Base.
  • If an abstract class is just intended to group reusable code shared by a number of subclasses, but is not intended as a general starting point then no prefix or suffix is added.
@pfrenssen pfrenssen added this to the 2.0-alpha1 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant