Caddy download URL is invalid or has changed

[alexellis]

Caddy download URL is invalid or has changed

Why do you need this?

Affecting a user on ARM64 in #267

Expected Behaviour

Download the correct Caddy binary from the latest URL:

https://github.com/caddyserver/caddy/releases/download/v2.5.0/caddy_2.5.0_linux_arm64.tar.gz

https://github.com/caddyserver/caddy/releases/download/v2.5.0/caddy_2.5.0_linux_armv7.tar.gz

Current Behaviour

The installation script currently adds a - character and creates a 404.

List All Possible Solutions and Workarounds

Remove the - prefix for ARMv7 and ARM64

Steps to Reproduce (for bugs)

1. Try installing faasd with Caddy enabled on one of these platforms.
2. Specify FAASD_DOMAIN before install.sh to see it in action.

Your Environment

Latest Caddy and faasd versions for ARM64 and Raspberry Pi.

cc @jsiebens as the problem may have been introduced in #131

Longer term, moving to an arkade app will reduce the complexity of building URLs i.e. #259 via @nitishkumar71

[alexellis]

With the change in place:

alex@bq:~/go/src/github.com/openfaas/faasd$ suffix=arm64 ;curl -sSL "https://github.com/caddyserver/caddy/releases/download/v2.4.3/caddy_2.4.3_linux_${suffix}.tar.gz" -o /tmp/caddy.tgz
alex@bq:~/go/src/github.com/openfaas/faasd$ file /tmp/caddy.tgz
/tmp/caddy.tgz: gzip compressed data, max compression, original size modulo 2^32 31154688

alex@bq:~/go/src/github.com/openfaas/faasd$ suffix=armv7 ;curl -sSL "https://github.com/caddyserver/caddy/releases/download/v2.4.3/caddy_2.4.3_linux_${suffix}.tar.gz" -o /tmp/caddy.tgz
alex@bq:~/go/src/github.com/openfaas/faasd$ file /tmp/caddy.tgz
/tmp/caddy.tgz: gzip compressed data, max compression, original size modulo 2^32 28074496