-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: vectorize german labels and cleanup taxonomy #11292
taxonomy: vectorize german labels and cleanup taxonomy #11292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11292 +/- ##
=======================================
Coverage 49.33% 49.33%
=======================================
Files 79 79
Lines 22510 22510
Branches 5387 5387
=======================================
Hits 11105 11105
Misses 10045 10045
Partials 1360 1360 ☔ View full report in Codecov by Sentry. |
They moved from 4 to 5 categories in summer 2024 https://haltungsform.de/wp-content/uploads/20240118_PM_Erweiterung-der-Haltungsformkennzeichnung_FINAL.pdf
/lint |
/lint |
/lint |
Which one is correct?
|
Quality Gate passedIssues Measures |
< de:Haltungsform | ||
de: Haltungsform 5 Bio, Haltungsform Bio, Haltungsform 5 | ||
xx: Haltungsform 5 | ||
image:de: haltungsform_5.79x90.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, some people have added image: properties, but they are currently not used. The website uses the filename to make the matching. It's good to have image: properties, but the file name should be the same as the tag id in the target language. e.g. for de: Haltungsform 5 Bio, the filename needs to be haltungsform-5-bio.79x90.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephanegigandet that should be in the wiki. The wiki suggests that that's the property used for images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@github-throwaway Right, I have updated https://wiki.openfoodfacts.org/Taxonomy_Properties#image to reflect the current state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@github-throwaway Thanks for all the addition and fixes!
There might be some issues with some of the file names, but we could maybe merge this PR as is (so that we get all the fixes), and make further fixes in new PRs.
What
Screenshot
Related issue(s) and discussion