Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: vectorize german labels and cleanup taxonomy #11292

Conversation

github-throwaway
Copy link
Contributor

@github-throwaway github-throwaway commented Jan 26, 2025

What

  • Replace pngs with svgs.
  • Cleanup taxonomy
  • Remove duplicates
  • Fix typos

Screenshot

Related issue(s) and discussion

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.33%. Comparing base (9141b72) to head (e4f9a23).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11292   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files          79       79           
  Lines       22510    22510           
  Branches     5387     5387           
=======================================
  Hits        11105    11105           
  Misses      10045    10045           
  Partials     1360     1360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-throwaway github-throwaway changed the title taxonomy: GitHub throwaway vectorize german labels taxonomy: vectorize german labels Jan 26, 2025
@teolemon teolemon added the German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam label Jan 27, 2025
@github-throwaway
Copy link
Contributor Author

/lint

@github-throwaway
Copy link
Contributor Author

/lint

@github-throwaway
Copy link
Contributor Author

/lint

@github-throwaway
Copy link
Contributor Author

Which one is correct?

< en:EU organic
en: LK-BIO-149
auth_address:en: Mündener Straße 19, 37218 , Witzenhausen, Germany
auth_name:en: Agreco R.F. Göderz GmbH
auth_url:en: http://agrecogmbh.de
country:en: Sri Lanka
eu_groups:en: en:EU Group A: unprocessed plant products,en:EU Group B: live animals or unprocessed animal products,en:EU Group D: processed agricultural products for use as food (*),
exceptions:en: en:except products covered by Annex III,en:in conversion products

< en:EU organic
en: LK-BIO-149
xx: LK-BIO-149
auth_address:en: Meeuwenlaan 4-6, 8011 BZ, Zwolle, Netherlands
auth_name:en: Control Union Certifications
auth_url:en: http://certification.controlunion.com
country:en: Sri Lanka
eu_groups:en: en:EU Group A: unprocessed plant products,en:EU Group B: live animals or unprocessed animal products,en:EU Group C: unprocessed aquaculture products and algae,en:EU Group D: processed agricultural products for use as food (*),en:EU Group E: processed agricultural products for use as feed (*),en:EU Group F: vegetative propagating material and seeds for cultivation
exceptions:en: en:in-conversion products,en:except products covered by Annex III

@github-throwaway github-throwaway changed the title taxonomy: vectorize german labels taxonomy: vectorize german labels and cleanup taxonomy Jan 31, 2025
@github-throwaway github-throwaway marked this pull request as ready for review January 31, 2025 11:57
@github-throwaway github-throwaway requested a review from a team as a code owner January 31, 2025 11:57
< de:Haltungsform
de: Haltungsform 5 Bio, Haltungsform Bio, Haltungsform 5
xx: Haltungsform 5
image:de: haltungsform_5.79x90.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, some people have added image: properties, but they are currently not used. The website uses the filename to make the matching. It's good to have image: properties, but the file name should be the same as the tag id in the target language. e.g. for de: Haltungsform 5 Bio, the filename needs to be haltungsform-5-bio.79x90.svg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanegigandet that should be in the wiki. The wiki suggests that that's the property used for images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-throwaway Right, I have updated https://wiki.openfoodfacts.org/Taxonomy_Properties#image to reflect the current state.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-throwaway Thanks for all the addition and fixes!

There might be some issues with some of the file names, but we could maybe merge this PR as is (so that we get all the fixes), and make further fixes in new PRs.

@stephanegigandet stephanegigandet merged commit cec7a08 into openfoodfacts:main Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do with unreferenced label assets?
4 participants