Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: correction root vegetable #11294

Closed
wants to merge 2 commits into from

Conversation

moon-rabbitOFF
Copy link
Contributor

No description provided.

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Jan 26, 2025
@moon-rabbitOFF moon-rabbitOFF changed the title correction root vegetable taxonomy: correction root vegetable Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.33%. Comparing base (9141b72) to head (fa61d8e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11294   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files          79       79           
  Lines       22510    22510           
  Branches     5387     5387           
=======================================
  Hits        11105    11105           
  Misses      10045    10045           
  Partials     1360     1360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-throwaway
Copy link
Contributor

/update_tests_results

@openfoodfacts-bot openfoodfacts-bot requested a review from a team as a code owner January 26, 2025 20:52
@@ -54354,9 +54354,9 @@ hi: मुख्य जड़वाले सब्जी
hr: korjenasto povrće s glavnim korijenom
eurocode_2_group_2:en: 8.38

# description:en:ROOT VEGETABLES are underground plant parts eaten by humans as food.
# description:en:ROOT VEGETABLES are underground plant parts eaten by humans as food. This ingredient shouldn't be under vegetable since it can contain potato which is not a vegetable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well potatoes are considered a vegetable in a lot of classification, like the Eurocode: https://web.archive.org/web/20170712020835/http://www.ianunwin.demon.co.uk/eurocode/docmn/ec99/ecmg08cl.htm#Listing

The Nutri-Score does not count them as fruits and vegetables, we use the Eurocodes for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants