Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folksonomy Engine isn't displayed for some products #9412

Closed
CharlesNepote opened this issue Nov 27, 2023 · 2 comments · Fixed by #9517 or #9487
Closed

Folksonomy Engine isn't displayed for some products #9412

CharlesNepote opened this issue Nov 27, 2023 · 2 comments · Fixed by #9517 or #9487
Labels
🐛 bug This is a bug, not a feature request. 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. P2

Comments

@CharlesNepote
Copy link
Member

At least: https://world.openfoodfacts.org/product/3033491485763/hipro-25g-proteines-vanille-cookie-danone

The template is simply not loaded by Product opener. I don't see any reason why.
@CharlesNepote CharlesNepote added the 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. label Nov 27, 2023
@teolemon
Copy link
Member

That's nice to know. I thought I was going mad, seeing this problem sporadically.

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. P2 labels Nov 28, 2023
@alexgarel
Copy link
Member

I find the problem:

Folksonomy script is searching for the div to add the properties to with $("div[itemtype='https://schema.org/Product']")

while this product has itemtype='https://schema.org/DietarySupplement' instead !

This property itemtype is set by Display.pm::display_product

I propose to use $("div.main-product") instead !

alexgarel added a commit that referenced this issue Dec 12, 2023
@alexgarel
fix: allow folksonomy engine on dietetary products
ab0f7ec 
fixes: #9412
@alexgarel alexgarel mentioned this issue Dec 12, 2023
Merged
alexgarel added a commit that referenced this issue Dec 12, 2023
@alexgarel
fix: allow folksonomy engine on dietetary products (#9517)
88ebf9e 
* fix: allow folksonomy engine on dietetary products

fixes: #9412
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug This is a bug, not a feature request. 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. P2
Projects
None yet
Milestone
No milestone
3 participants
@alexgarel @CharlesNepote @teolemon