Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboarding will silently fail (+ timeout) #6162

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 9, 2025

Hi everyone!

The onboarding is a crucial part of the app.
So instead of waiting for ages, there's now a timeout + no error banner

@g123k g123k changed the title feat: Onboarding will silently fail (+ timeout feat: Onboarding will silently fail (+ timeout) Jan 9, 2025
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.34%. Comparing base (4d9c7fc) to head (1d27535).
Report is 629 commits behind head on develop.

Files with missing lines Patch % Lines
.../smooth_app/lib/data_models/onboarding_loader.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6162      +/-   ##
==========================================
- Coverage     9.54%   6.34%   -3.21%     
==========================================
  Files          325     450     +125     
  Lines        16411   25884    +9473     
==========================================
+ Hits          1567    1642      +75     
- Misses       14844   24242    +9398     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit d7a2176 into openfoodfacts:develop Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants