Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get notebooks building again #27

Merged
merged 17 commits into from
Mar 20, 2024
Merged

Get notebooks building again #27

merged 17 commits into from
Mar 20, 2024

Conversation

Yoshanuikabundi
Copy link
Contributor

@Yoshanuikabundi Yoshanuikabundi commented Dec 18, 2023

For some reason I though GitHub would tell me when all the actions on this repo were failing.

TODOS:

  • Get things working by explicitly skipping some notebooks
  • Automatically skip notebooks that can't execute
  • Notify package owners when their notebook isn't on the examples page

Copy link

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7247042253
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7247042253
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[16], line 30
     23 energy_difference = abs(off_ene - omm_ene)
     26 # For some reason, there is a slight coordinate/energy difference between the OpenFF
     27 # TIP5P virtual sites and the OpenMM TIP5P virtual sites. The energy difference appears
     28 # to be entirely due to slightly different geometry.
     29 assert (
---> 30     coordinate_difference < 0.04
     31 ), f"Coordinates differ by a norm of {coordinate_difference}"
     32 assert (
     33     energy_difference < 1.0 * openmm.unit.kilojoule_per_mole
     34 ), f"Energies differ by {energy_difference}"

AssertionError: Coordinates differ by a norm of 3.0895671596164282


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/micromamba/envs/openff-docs-examples/lib/python3.10/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/home/runner/work/openff-docs/openff-docs/source/_ext/proc_examples.py", line 202, in execute_notebook
    raise ValueError(f"Exception encountered while executing {src_rel}")
ValueError: Exception encountered while executing openforcefield/openff-toolkit/virtual_sites/vsite_showcase.ipynb
"""

I can reproduce locally. Will pin a version of the toolkit that doesn't have this error.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7247520513
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7247520513
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7247550785
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7247550785
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@mattwthompson
Copy link
Member

I though GitHub would tell me when all the actions on this repo were failing.

I've been getting emails since ~Friday. I previously thought the most recent committer to the default branch got these, now I guess not

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7248916071
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

@Yoshanuikabundi
Copy link
Contributor Author

I found an option in my account settings to be notified about failing GitHub actions and I'm getting them now :)

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7248916071
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7249054053
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7249054053
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7249260096
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7249260096
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 7257811427
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 7257811427
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi Yoshanuikabundi mentioned this pull request Jan 10, 2024
@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 8336134619
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 8336134619
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 8336211463
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 8336211463
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 8342106212
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 8342106212
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 8356303774
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 8356303774
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: failure

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 8357133908
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 8357133908
  • Triggering actor: github-actions[bot]
  • Target branch: fix-actions
  • Deployment branch: _cookbook_data_PR27
  • Status: success

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

@Yoshanuikabundi Yoshanuikabundi changed the title Fix broken actions Get notebooks building again Mar 20, 2024
@Yoshanuikabundi Yoshanuikabundi merged commit 383a326 into main Mar 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants