Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AttributeClass initialization #606

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Add AttributeClass initialization #606

merged 3 commits into from
Feb 5, 2025

Conversation

lilyminium
Copy link
Contributor

Fixes #605

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (3b38655) to head (55ae7a6).
Report is 6 commits behind head on main.

Additional details and impacted files

@lilyminium lilyminium marked this pull request as ready for review January 21, 2025 02:40
@lilyminium lilyminium mentioned this pull request Jan 21, 2025
Draft
mattwthompson
mattwthompson approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, I trust this enables some of your work that you'd otherwise find clunky in a way you don't prefer. And this is a backwards-compatible change, i.e. the "instantiate and set" pattern is unaffected

@lilyminium
Copy link
Contributor Author

Thanks Matt!

@lilyminium lilyminium merged commit 7d927d9 into main Feb 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwthompson mattwthompson mattwthompson approved these changes

Assignees

@mattwthompson mattwthompson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow AttributeClasses to be initialized with values
2 participants
@lilyminium @mattwthompson