-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Micro Manager: a Python package for adaptive and flexible two-scale coupling #5842
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Review checklist for @mayrmtConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @mrogowskiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@IshaanDesai: It seems that this is missing. Let me know if I missed it. Something like a simple |
@mrogowski yes it is missing, thanks for spotting this! I will add a |
@editorialbot generate pdf |
@mrogowski I added a |
Hi @mbkumar, a reminder about this review. Thanks! |
Review checklist for @mbkumarConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Sorry for the delay in starting the review. Since this is an addon package, installation is difficult. I installed libprecice v2.5.0, however, the documentation is not helping me figure out how to install the latest version of pyprecice. Can the authors point to a dev container, which can aid in the installation and testing of micromanager? |
I have tested the software and found it to be rough around the edges. It could be improved in a few aspects. For example, instead of using a fixed name for the MicroManager class, it could be made an abstract class. Then users could subclass it and the macro-manager could be supplied the subclass name in its config file. But, the software is useful and useable in its present form. The manuscript is reasonably good. So, I recommend its publication. |
Thank you @mbkumar for the testing the Micro Manager, opening issues for things that did not work, and reviewing the manuscript. We really appreciate it! At some point we had a configurable class name for the |
Hi @IshaanDesai, have you addressed all outstanding issues from @mrogowski and @mayrmt? |
Hi @philipcardiff, yes, so far everything has been addressed. |
Thanks @IshaanDesai. @mrogowski and @mayrmt: I see your checklists are not yet complete; do you have other comments, queries or suggestions? |
@philipcardiff I have update my checklist. No further comments from my side! |
Hi @kyleniemeyer, this paper is ready for processing. |
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4760, then you can now move forward with accepting the submission by compiling again with the command |
@philipcardiff the archive link is 10.18419/darus-3764 and not the Zenodo link that you pointed to. That one appears to be for another software. Could we please reset it? |
@editorialbot set 10.18419/darus-3764 as archive |
Done! archive is now 10.18419/darus-3764 |
Thanks. Sorry, this was a copy'n'paste error. It should be correct now. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4763, then you can now move forward with accepting the submission by compiling again with the command |
👋 @IshaanDesai - I'm the track editor for this submission, and I'll process the remaining steps. I'll next proofread the paper, and let you know if you need to do anything else. |
I've suggested a few small changes in precice/micro-manager#71 - please merge this, or let me know what you disagree with, then we can continue towards acceptance and publication |
@editorialbot recommend-accept |
@danielskatz thanks for proofreading and suggesting changes, I have merged them now. |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4764, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @IshaanDesai (Ishaan Desai) and co-authors!! And thanks to @mayrmt, @mrogowski, and @mbkumar for reviewing, and to @philipcardiff for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @IshaanDesai (Ishaan Desai)
Repository: https://github.com/precice/micro-manager
Branch with paper.md (empty if default branch): joss-submission
Version: v0.3.0
Editor: @philipcardiff
Reviewers: @mayrmt, @mrogowski, @mbkumar
Archive: 10.18419/darus-3764
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@mayrmt & @mrogowski & @mbkumar, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @philipcardiff know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @mayrmt
📝 Checklist for @mrogowski
📝 Checklist for @mbkumar
The text was updated successfully, but these errors were encountered: