Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution guidelines should mention DCO signoff #16

Open
tanto259 opened this issue May 17, 2021 · 2 comments
Open

Contribution guidelines should mention DCO signoff #16

tanto259 opened this issue May 17, 2021 · 2 comments

Comments

@tanto259
Copy link
Member

PR #15 added some guideline for contribution to the project. However, DCO signoff was not mentioned and it seems that many commits had been manually signed-off.

I would propose that we add DCO signoff as a requirement for future contribution to ensure that those who are submitting work only do so when they have the rights to do so.

This would be as simple as adding the --signoff option to git commit. Furthermore, I would propose the adoption of CONTRIBUTING.md to ensure that all the styles and requirements for contributions are followed.

I will be happy to submit a PR to add these materials :)

@SweetJenn23
Copy link

Hey Hartanto! We are looking into this . . . Because we're not working with source code but instead documents, we are needing to discern which apply and which don't. We will keep you posted!! Thanks for this!

@tanto259
Copy link
Member Author

Thanks!

My concern is when we start seeing contributions, we need to make sure that they have the rights to distribute the materials, especially if it came from organizations. Therefore, having DCO signoffs will prevent any possible issues in the future :)

Additionally, I believe the language used in the DCO is "contribution" so it should cover everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants