Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a package #69

Open
shimwell opened this issue May 11, 2022 · 0 comments
Open

Create a package #69

shimwell opened this issue May 11, 2022 · 0 comments

Comments

@shimwell
Copy link
Member

shimwell commented May 11, 2022

If this collection of scripts were converted to a package then it might facilitate testing, reuse of code and distribution.

I've been working on a possible route to converting this repo into a package and here is a link to what I'm thinking https://github.com/openmc-data-storage/openmc_data

  • Scripts can all become accessible from the command line so they can be run easily from the terminal (partly implemented).
  • Testing of that the download urls are still being alive has been partly implemented.
  • Testing that each script file exists has been partly implemented
  • a single utils file has been made (we use to have two identical files)
  • additional shared code has been moved the utils file
  • Some more standardisation has been rolled out showing how the deplete scripts could be most similar to the convert scripts (which then allows duplicate code to be removed)

This is a working progress but I wanted to share this idea which brings together a few of the exiting PRs on this data repo. If the idea is welcome then the package can be tidied up and moved over to this org.

@shimwell shimwell linked a pull request Jul 1, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant